Review main Merged

8728[BUGFIX] Loading of an IRRE element with subtabs freezes and breaks browsers

Stefan Galinski CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Oliver Klee +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Files 1

Review log 11

  1. Tolleiv Nietsch commented on patch set 1 02/09/12, 07:47

    (1 inline comment)

    tabmenu.js:25

    I'd prefer "var DTM_array = DTM_array || []"
  2. Stefan Galinski uploaded patch set 2 02/09/12, 07:47

  3. Tolleiv Nietsch commented on patch set 3 V 0 02/09/12, 07:47

    by team member; Looks good to me, approved
  4. Tolleiv Nietsch commented on patch set 3 02/09/12, 07:47

    Verified; Looks good to me, but someone else must approve
  5. Oliver Klee commented on patch set 3 02/09/12, 07:47

    Looks good to me, but someone else must approve
  6. Stefan Galinski uploaded patch set 3 02/09/12, 07:47

  7. Philipp Gampe commented on patch set 3 02/09/12, 07:47

    Verified; Looks good to me, but someone else must approve Thanks. I had this problem lately.
  8. Mr. Jenkins commented on patch set 1 02/09/12, 07:47

  9. Mr. Jenkins commented on patch set 2 02/09/12, 07:47

  10. Mr. Jenkins commented on patch set 3 02/09/12, 07:47

  11. Tolleiv Nietsch merged patch set 3 02/09/12, 07:47