Review main Merged

87434[BUGFIX] Allow defining background for vimeo videos

Benni Mack CR +2 V +2 Easy +3 −2 updated 01/07/25, 10:10

Commit message

This change allows to configure the "&background=1"
on Vimeo Videos embedded in TYPO3.

Adding this parameter will have the following effect:

- All player toggles and elements will be turned off (including the play/pause button!)
- The video will automatically loop.
- The video will be set to autoplay.
- The video will be muted.

https://help.vimeo.com/hc/en-us/articles/12426285089681-How-to-embed-background-and-chromeless-videos

This is especially helpful for e.g. background / teaser videos.

This change is declared as bugfix, as this option
was missing when Vimeo rendering was introduced.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 12/11/24, 11:13

  2. core-ci voted on patch set 1 V +1 12/11/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70916

  3. Andreas Kienast voted on patch set 1 CR +1 12/11/24, 13:19

  4. Benjamin Franzke voted on patch set 1 CR +1 V +1 01/07/25, 08:31

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 01/07/25, 10:04

  6. Benni Mack voted on patch set 1 CR +2 V +2 01/07/25, 10:10

  7. Benni Mack merged patch set 2 01/07/25, 10:10