Review main Merged

87592[BUGFIX] Add margin to upload button in filelist module

Torben Hansen CR +2 V +2 Easy +1 −1 updated 01/02/25, 10:25

Commit message

When an empty folder is displayed in the filelist module,
an upload button is shown. Clicking this button leads to a
dedicated upload view. In this view, an infobox is shown,
which has no top margin to the previous upload button.

This change adds the necessary margin to the upload
button div.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 12/24/24, 06:16

  2. core-ci voted on patch set 1 V +1 12/24/24, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71598

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 12/24/24, 14:23

  4. Josef Glatz commented on patch set 1 CR +1 V +1 12/26/24, 18:24

    nice catch
  5. Stefan Bürk voted on patch set 1 CR +2 V +2 01/02/25, 10:12

  6. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 01/02/25, 10:13

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 01/02/25, 10:18

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 01/02/25, 10:21

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 01/02/25, 10:21

  10. core-ci voted on patch set 2 V +1 01/02/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71805

  11. Stefan Bürk merged patch set 3 01/02/25, 10:25