87593[!!!][TASK] Change logout handling in ext:felogin
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-103910-ChangeLogoutHandlingInExtfelogin.rst2new+66 −0
- typo3/sysext/felogin/Classes/Controller/LoginController.php+3 −9
- typo3/sysext/felogin/Classes/Redirect/RedirectHandler.php+0 −15
- typo3/sysext/felogin/Resources/Private/Templates/Login/Logout.html3+4 −1
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+0 −60
Review log 1621
-
Torben Hansen uploaded patch set 1 12/24/24, 13:39
-
core-ci voted on patch set 1 V +1 12/24/24, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71601
-
Torben Hansen rebased onto patch set 2
V +101/18/25, 12:34 -
core-ci voted on patch set 2 V +1 01/18/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72658
-
Torben Hansen uploaded patch set 3
V +101/19/25, 06:27 -
core-ci voted on patch set 3 V +1 01/19/25, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72677
-
Oliver Hader commented on patch set 3 01/23/25, 14:56
-
Torben Hansen commented on patch set 3 02/14/25, 12:47
Logout.html:27ReplyGood point. Actually, this is a boolean value, which never can be an empty string. The `noRedirect` evaluation is however broken anyway, since it currently is only respected via settings and not, as it should, also via GET and POST parameter. In the legacy version of ext:felogin, it was evaluated via `$this->noRedirect = $this->piVars['noredirect'] || $this->conf['redirectDisable'];`, but this was implemented wrong in `isRedirectDisabled` function in the extbase version of the extension, where it is only checked, if there is an argument named `noredirect`. I think, the parameter evaluation could be fixed, so if can also be provided via url (`0` and `1` as accepted values). Since this also would be a breaking change, I opt to create an additional patch for this. -
Torben Hansen uploaded patch set 4
V +103/09/25, 12:28 -
core-ci voted on patch set 4 V +1 03/09/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75372
-
Benni Mack commented on patch set 4 CR -2 03/10/25, 10:57
need to check the RST -
Benni Mack voted on patch set 4 CR +1 V +1 03/22/25, 15:06
-
Markus Klein voted on patch set 4 CR +1 V +1 03/24/25, 11:48
-
Georg Ringer commented on patch set 4 03/24/25, 20:02
Breaking-103910-ChangeLogoutHandlingInExtfelogin.rst:41html? also below -
Benni Mack commented on patch set 5
CR +1V +103/24/25, 20:02Published edit on patch set 4. -
Georg Ringer voted on patch set 5 CR +1 V +1 03/24/25, 20:04
-
core-ci voted on patch set 5 V +1 03/24/25, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76167
-
Markus Klein commented on patch set 5 CR +1 V +1 03/25/25, 08:21
Breaking-103910-ChangeLogoutHandlingInExtfelogin.rst:41ReplyDoneLogout.html:27ReplyDone -
Benni Mack voted on patch set 5 CR +2 V +2 03/25/25, 08:43
-
Benni Mack merged patch set 6 03/25/25, 08:43
-
Lina Wolf commented on patch set 6 03/29/25, 07:52
Please review related doc changes: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/5476
Logout.html:27