Review main Merged Breaking

87593[!!!][TASK] Change logout handling in ext:felogin

Torben Hansen CR +2 V +2 Normal +73 −85 updated 03/29/25, 07:52

Commit message

When a logout redirect is configured in ext:felogin, the extension
sets the target URL for the redirect as action for the logout
form. Although the logout process works as expected, it is
technically wrong to use the redirect target URL as action, because
the `LogoutConfirmedEvent` PSR-14 event in the `loginAction` is not
dispatched in this scenario.

With this change, the form action for the logout form is now
changed to the `loginAction` of the `LoginController`. The extension
will now correctly dispatch the `LogoutConfirmedEvent` PSR-14 event
and will perform the redirect to the configured redirect URL,
which is evaluated in `initializeAction`.

The `actionUri` variable has been removed and the logout fluid
template has been adapted, so the removed variable is not used
any more. Additionally, the template now correctly sets the
hidden field `noredirect`, which was missing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1621

  1. Torben Hansen uploaded patch set 1 12/24/24, 13:39

  2. core-ci voted on patch set 1 V +1 12/24/24, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71601

  3. Torben Hansen rebased onto patch set 2 V +1 01/18/25, 12:34

  4. core-ci voted on patch set 2 V +1 01/18/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72658

  5. Torben Hansen uploaded patch set 3 V +1 01/19/25, 06:27

  6. core-ci voted on patch set 3 V +1 01/19/25, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72677

  7. Oliver Hader commented on patch set 3 01/23/25, 14:56

    Logout.html:27

    Just wondering why `!=''` is required here
  8. Torben Hansen commented on patch set 3 02/14/25, 12:47

    Logout.html:27 Reply

    Good point. Actually, this is a boolean value, which never can be an empty string. The `noRedirect` evaluation is however broken anyway, since it currently is only respected via settings and not, as it should, also via GET and POST parameter. In the legacy version of ext:felogin, it was evaluated via `$this->noRedirect = $this->piVars['noredirect'] || $this->conf['redirectDisable'];`, but this was implemented wrong in `isRedirectDisabled` function in the extbase version of the extension, where it is only checked, if there is an argument named `noredirect`. I think, the parameter evaluation could be fixed, so if can also be provided via url (`0` and `1` as accepted values). Since this also would be a breaking change, I opt to create an additional patch for this.
  9. Torben Hansen uploaded patch set 4 V +1 03/09/25, 12:28

  10. core-ci voted on patch set 4 V +1 03/09/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75372

  11. Benni Mack commented on patch set 4 CR -2 03/10/25, 10:57

    need to check the RST
  12. Benni Mack voted on patch set 4 CR +1 V +1 03/22/25, 15:06

  13. Markus Klein voted on patch set 4 CR +1 V +1 03/24/25, 11:48

  14. Georg Ringer commented on patch set 4 03/24/25, 20:02

    Breaking-103910-ChangeLogoutHandlingInExtfelogin.rst:41

    html? also below
  15. Benni Mack commented on patch set 5 CR +1 V +1 03/24/25, 20:02

    Published edit on patch set 4.
  16. Georg Ringer voted on patch set 5 CR +1 V +1 03/24/25, 20:04

  17. core-ci voted on patch set 5 V +1 03/24/25, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76167

  18. Markus Klein commented on patch set 5 CR +1 V +1 03/25/25, 08:21

    Breaking-103910-ChangeLogoutHandlingInExtfelogin.rst:41 Reply

    Done

    Logout.html:27 Reply

    Done
  19. Benni Mack voted on patch set 5 CR +2 V +2 03/25/25, 08:43

  20. Benni Mack merged patch set 6 03/25/25, 08:43

  21. Lina Wolf commented on patch set 6 03/29/25, 07:52