Review main Abandoned

87607[DOCS] Fix: Update user reference from backend to front-end user for password recovery feature

TYPO3com CR 0 V 0 Easy +2 −2 updated 01/02/25, 12:58

Commit message

- Changed `be_users` to `fe_users` and updated the terminology from
"backend user" to "front-end user" in the password recovery FluidEmail.
- The `{userData}` variable now correctly refers to front-end user data
from the `fe_users` table.
- Clarified that this feature works in the front-end context.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 58

  1. TYPO3com uploaded patch set 1 12/31/24, 07:00

  2. Himanshu Nitsan updated the commit message in patch set 2 12/31/24, 07:02

  3. core-ci voted on patch set 1 V +1 12/31/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71749

  4. core-ci voted on patch set 2 V +1 12/31/24, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71750

  5. Garvin Hicking commented on patch set 2 CR -2 12/31/24, 07:47

    Sorry, but this is not right. the changelog refers to issue 103147 and that introduced fhese variabkes for the backend, not the frontend. Could you elaborate on this, have you seen the actual patch, might I be missing something? Maybe you searched for keywords and found this page but instead you would want to see documentation on fluidrecovery and the frontend?
  6. Himanshu Nitsan commented on patch set 2 12/31/24, 09:18

    Reply

    As you can see in the screenshot, this is used in the felogin plugin for the recovery password form. so maybe in this place, fe_user is correct instead of be_user. https://tinyurl.com/2dqxec92
  7. Garvin Hicking commented on patch set 2 12/31/24, 09:40

    Reply

    There are twocpassword recoverie methods: fe and be. fe worked all the time. be worked only when it was changed with the changelog entry So the changelog entry only refers to that BE change.
  8. Garvin Hicking abandoned the change 01/02/25, 12:58

    Hope its ok to abandon due to the reasoning above