Review 12.4 Merged

87683[BUGFIX] Use correct log level in TypoScriptParser

Georg Ringer CR +2 V +2 Easy +1 −1 updated 01/13/25, 18:55

Commit message

`1` isn't a valid log level and should be removed.

(Note that this was contained in the "old" TypoScript
Parser that was removed in v13, so this only applies
to v12 and below)

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Georg Ringer uploaded patch set 1 01/09/25, 19:52

  2. Georg Ringer commented on patch set 1 01/09/25, 19:52

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/09/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72168

  4. Garvin Hicking updated the commit message in patch set 2 V +1 01/09/25, 20:23

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 01/09/25, 20:23

  6. core-ci voted on patch set 2 V +1 01/09/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72169

  7. Andreas Kienast commented on patch set 2 01/10/25, 07:45

    TypoScriptParser.php:275

    I think it makes sense to remove `int|` from the type annotation of `error()` as well.
  8. Christian Kuhn commented on patch set 2 CR +1 V +1 01/13/25, 17:48

    TypoScriptParser.php:275 Reply

    I agree this would be more correct. Considering TypoScriptParser is legacy in v12 and removed since v13, I'd argue adapting this does not make much of a difference, though. I'd go with the proposed solution only if that is fine with you.
  9. Christian Kuhn commented on patch set 2 CR +2 V +2 01/13/25, 18:55

    got "ack" from Andreas and will merge now.
  10. Christian Kuhn merged patch set 3 01/13/25, 18:55