Review main Merged

87684[BUGFIX] Rework Flexform data handling in TcaFlexPrepare

Georg Ringer CR +2 V +2 Easy +10 −11 updated 01/13/25, 13:01

Commit message

The previous code in `TcaFlexPrepare->initializeDataValues()` was pretty
optimistic regarding the incoming data and may booted XML parsing on
empty strings and did not consider `null` values.

The code is changed to check now whether the incoming data is not null
and not an empty string before using it at all.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1517

  1. Georg Ringer uploaded patch set 1 01/09/25, 20:50

  2. Georg Ringer commented on patch set 1 01/09/25, 20:50

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/09/25, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72170

  4. Andreas Kienast commented on patch set 1 CR -1 01/10/25, 07:51

    TcaFlexPrepare.php:103

    Ain't it easier to check for a non-null value here instead of booting all the XML Parser stuff for an empty string?
  5. Andreas Kienast commented on patch set 1 01/10/25, 08:09

    Will push an update
  6. Andreas Kienast uploaded patch set 2 CR -1 V +1 01/10/25, 08:23

  7. Andreas Kienast commented on patch set 2 01/10/25, 08:28

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 01/10/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72194

  9. Georg Ringer voted on patch set 2 CR +1 V +1 01/10/25, 08:38

  10. Andreas Kienast commented on patch set 2 01/13/25, 10:30

    TcaFlexPrepare.php:103 Reply

    Done
  11. Christian Kuhn voted on patch set 2 CR +1 V +1 01/13/25, 10:45

  12. Oli Bartsch commented on patch set 2 01/13/25, 11:07

    TcaFlexPrepare.php:98

    Shouldn't this check go into 101 as the value might be an array?
  13. Andreas Kienast commented on patch set 2 01/13/25, 11:17

    TcaFlexPrepare.php:98 Reply

    This won't make any difference. If the value is an array, the code in line 99 is executed
  14. Andreas Kienast voted on patch set 2 CR +1 V +1 01/13/25, 12:37

  15. Oli Bartsch commented on patch set 2 01/13/25, 12:47

    TcaFlexPrepare.php:98 Reply

    Acknowledged
  16. Christian Kuhn voted on patch set 2 CR +2 V +2 01/13/25, 12:53

  17. Christian Kuhn merged patch set 3 01/13/25, 13:01