87684[BUGFIX] Rework Flexform data handling in TcaFlexPrepare
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1517
-
Georg Ringer uploaded patch set 1 01/09/25, 20:50
-
Georg Ringer commented on patch set 1 01/09/25, 20:50
This change is ready for review. -
core-ci voted on patch set 1 V +1 01/09/25, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72170
-
Andreas Kienast commented on patch set 1 CR -1 01/10/25, 07:51
TcaFlexPrepare.php:103Ain't it easier to check for a non-null value here instead of booting all the XML Parser stuff for an empty string? -
Andreas Kienast commented on patch set 1 01/10/25, 08:09
Will push an update -
Andreas Kienast uploaded patch set 2
CR -1V +101/10/25, 08:23 -
Andreas Kienast commented on patch set 2 01/10/25, 08:28
Reply
Done -
core-ci voted on patch set 2 V +1 01/10/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72194
-
Georg Ringer voted on patch set 2 CR +1 V +1 01/10/25, 08:38
-
Andreas Kienast commented on patch set 2 01/13/25, 10:30
TcaFlexPrepare.php:103ReplyDone -
Christian Kuhn voted on patch set 2 CR +1 V +1 01/13/25, 10:45
-
Oli Bartsch commented on patch set 2 01/13/25, 11:07
TcaFlexPrepare.php:98Shouldn't this check go into 101 as the value might be an array? -
Andreas Kienast commented on patch set 2 01/13/25, 11:17
TcaFlexPrepare.php:98ReplyThis won't make any difference. If the value is an array, the code in line 99 is executed -
Andreas Kienast voted on patch set 2 CR +1 V +1 01/13/25, 12:37
-
Oli Bartsch commented on patch set 2 01/13/25, 12:47
TcaFlexPrepare.php:98ReplyAcknowledged -
Christian Kuhn voted on patch set 2 CR +2 V +2 01/13/25, 12:53
-
Christian Kuhn merged patch set 3 01/13/25, 13:01