Review main Merged

87721[BUGFIX] Allow record type with dots

Oli Bartsch CR +2 V +2 Normal +53 −20 updated 01/20/25, 11:22

Commit message

RawRecord does now properly handle record
types, using dot(s).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1724

  1. Oli Bartsch uploaded patch set 1 01/13/25, 17:26

  2. core-ci voted on patch set 1 V +1 01/13/25, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72373

  3. Oliver Klee updated the commit message in patch set 2 V +1 01/13/25, 18:18

  4. core-ci voted on patch set 2 V +1 01/13/25, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72376

  5. Christian Kuhn commented on patch set 2 01/14/25, 14:15

    RawRecordTest.php:48

    this looks unfinished?
  6. Oli Bartsch uploaded patch set 3 V +1 01/15/25, 09:46

  7. Oli Bartsch commented on patch set 3 01/15/25, 09:46

    RawRecordTest.php:48 Reply

    Thanks.
  8. Oli Bartsch uploaded patch set 4 01/15/25, 09:47

  9. core-ci voted on patch set 3 V -1 01/15/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72510

  10. core-ci voted on patch set 4 V +1 01/15/25, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72511

  11. Oliver Hader commented on patch set 4 01/20/25, 08:33

    RawRecordTest.php:55

    What do you think about adding an additional test for `tt_content.` Should the result be `['tt_content', '']` or `['tt_content', null]`?
  12. Oli Bartsch uploaded patch set 5 V +1 01/20/25, 08:54

  13. Oli Bartsch commented on patch set 5 01/20/25, 08:55

    RawRecordTest.php:55 Reply

    Should be NULL. I added the test and also corresponding PHPDoc comment.
  14. core-ci voted on patch set 5 V -1 01/20/25, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72712

  15. Oli Bartsch uploaded patch set 6 V -1 01/20/25, 09:29

  16. core-ci voted on patch set 6 V +1 01/20/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72714

  17. Oliver Hader uploaded patch set 7 V +1 01/20/25, 10:35

  18. Oliver Hader voted on patch set 7 CR +1 V +1 01/20/25, 10:37

  19. core-ci voted on patch set 7 V +1 01/20/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72722

  20. Benni Mack voted on patch set 7 CR +1 V +1 01/20/25, 10:52

  21. Oli Bartsch voted on patch set 7 CR +2 V +2 01/20/25, 11:09

  22. Oli Bartsch merged patch set 8 01/20/25, 11:09

  23. Christian Kuhn commented on patch set 8 01/20/25, 11:17

    RawRecordTest.php:53

    this is one data tuple too much, is it?
  24. Oli Bartsch commented on patch set 8 01/20/25, 11:22

    RawRecordTest.php:53 Reply