87722[BUGFIX] Use field labels in record download for processed values
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1520
-
Oli Bartsch uploaded patch set 1 01/13/25, 21:57
-
core-ci voted on patch set 1 V +1 01/13/25, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72379
-
Garvin Hicking wrote 01/14/25, 06:09
Topic set to recordlist -
Garvin Hicking updated the commit message in patch set 2
V +101/14/25, 06:12 -
core-ci voted on patch set 2 V +1 01/14/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72395
-
Garvin Hicking updated the commit message in patch set 3
V +101/14/25, 07:55 -
Garvin Hicking voted on patch set 3 CR +1 V +1 01/14/25, 07:55
-
core-ci voted on patch set 3 V +1 01/14/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72396
-
Oli Bartsch uploaded patch set 4
CR +1V +101/14/25, 08:08 -
Garvin Hicking voted on patch set 4 CR +1 V +1 01/14/25, 08:11
-
core-ci voted on patch set 4 V +1 01/14/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72398
-
Stefan Bürk commented on patch set 4 01/14/25, 22:58
RecordListDownloadController.php:163Why using $label and not assigning to $headerField directly ? Same for the elsif branch which would make the 3rd else branch obsolete .... Kind of confusing the forth and back between the variables here. -
Oli Bartsch commented on patch set 4 01/15/25, 07:20
RecordListDownloadController.php:163ReplyI do not understand this. IMO we can not overwrite $headerField at the beginning as it is used in the translateLabel() method to check for tsConfig for this field name. However, I may have missed something and would be more than happy if you could simplify the patch. -
Oli Bartsch uploaded patch set 5
CR +1V +101/18/25, 12:34 -
Oli Bartsch commented on patch set 5 01/18/25, 12:35
RecordListDownloadController.php:163ReplyDone -
core-ci voted on patch set 5 V +1 01/18/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72659
-
Garvin Hicking voted on patch set 5 CR +1 V +1 01/18/25, 19:03
-
Stefan Bürk voted on patch set 5 CR +1 V +1 01/19/25, 17:54
-
Oli Bartsch voted on patch set 5 CR +2 V +2 01/20/25, 08:49
-
Oli Bartsch merged patch set 6 01/20/25, 08:49