Review main Merged

8776[BUGFIX] New form wizard not loading in IE8

Sebastian Schawohl CR +2 V +2 Easy +18 −18 updated 06/03/13, 20:49

Commit message

Internet Explorer 8 raises an error on JavaScript objects with reserved
words as property names. In the new form wizard an object was created
with class as property name which is a reserved word. Surrounding with
quotes fixes the bug.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Mario Rimann +1
    • Wouter Wolters +1
    • Dmitry Dulepov +1

Files 18

Review log 19

  1. Steffen Gebert uploaded patch set 2 10/22/12, 13:31

    Please mention 4.7 also here!
  2. Tolleiv Nietsch commented on patch set 3 10/22/12, 13:31

    Looks good to me, approved Sorry don't have an IE8 at hand atm ... looks reasonable.
  3. Steffen Gebert commented on patch set 3 10/22/12, 13:31

    (1 inline comment) Thanks a lot for your patch. I've added 4.7 to the list of affected releases.
  4. Steffen Gebert uploaded patch set 3 10/22/12, 13:31

  5. Philipp Gampe commented on patch set 3 10/22/12, 13:31

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 10/22/12, 13:31

  7. Mr. Jenkins commented on patch set 2 10/22/12, 13:31

  8. Mr. Jenkins commented on patch set 3 10/22/12, 13:31

  9. Wouter Wolters commented on patch set 3 10/22/12, 13:31

    Verified; I would prefer that you didn't submit this The patch does not apply anymore. Don't no why but was not able to get my environment running after applying this patch. So I did the change in an own local branch. Tested it in IE8 and the wizard is working again. @Tolleiv maybe you know how I can rebase such a patch?
  10. Mario Rimann commented on patch set 4 10/22/12, 13:31

    Verified; Looks good to me, but someone else must approve Tested on a 6.0-dev Installation -> works fine!
  11. Mario Rimann commented on patch set 4 10/22/12, 13:31

    Ping
  12. Dmitry Dulepov commented on patch set 4 10/22/12, 13:31

    Verified; Looks good to me, approved
  13. Stefan Neufeind commented on patch set 4 10/22/12, 13:31

    Looks good to me, but someone else must approve We can't change to a different variable-name, can we?
  14. Christian Kuhn commented on patch set 4 V 0 10/22/12, 13:31

    by team member; Looks good to me, approved
  15. Mr. Jenkins commented on patch set 4 10/22/12, 13:31

  16. Wouter Wolters commented on patch set 4 10/22/12, 13:31

    Verified; Looks good to me, but someone else must approve Rebased, IMHO this patch had enough votes:-)
  17. Wouter Wolters uploaded patch set 4 10/22/12, 13:31

  18. Florian Scholz commented on patch set 3 10/22/12, 13:31

    Looks good to me, but someone else must approve The FormWizard loads at least now. It seems like there other issues, though (validation, adding elements). Might need to file some follow-up bugs on that.
  19. Christian Kuhn merged patch set 4 10/22/12, 13:31