Review main Merged

87787[BUGFIX] Restore dropdown end alignment support

Benjamin Kott CR +2 V +2 Easy +24 −0 updated 01/17/25, 09:52

Commit message

Fixes an oversight during the dropdown component
extraction, where Bootstrap's use of a custom CSS
property to configure Popper.js alignment was omitted.

This patch reinstates support for aligning dropdown
menus to the end position. Future updates will replace
JavaScript handling with the Popover API and Anchor
Positioning API once widely supported.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Benjamin Kott uploaded patch set 1 01/17/25, 09:10

  2. Benjamin Kott commented on patch set 1 01/17/25, 09:15

    This can be tested, by checking the alignment of the dropdown of the tree toolbar options.
  3. core-ci voted on patch set 1 V +1 01/17/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72606

  4. Andreas Kienast commented on patch set 1 V -1 01/17/25, 09:38

    Does not work in RLT languages :/
  5. Andreas Kienast commented on patch set 1 01/17/25, 09:38

    Reply

    RTL, of course...
  6. Andreas Kienast commented on patch set 1 CR +1 V +1 01/17/25, 09:40

    Reply

    Never mind, the JavaScript binding isn't re-evaluated after changing the language. Reloading the backend is necessary here.
  7. Benjamin Franzke voted on patch set 1 CR +1 V +1 01/17/25, 09:45

  8. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/17/25, 09:46

  9. Benjamin Franzke merged patch set 2 01/17/25, 09:52