Review main Merged

87973[TASK] Add type hints in BackendUtility for some methods

Anja Leichsenring CR +2 V +2 Normal +62 −76 updated 01/31/25, 21:46

Commit message

Starting with `getQueryBuilderForTable()` and `getConnectionForTable()`,
type hints and return types are added to the functions and their
consumers. This is only done in cases the change is considered safe,
thus where a type error would be raised by subsequential method calls
that have the type already annotated.

As a drive by improvement, the mentioned helper methods are now used
consistently within the class and always called via `self::`, because
the class provides a static context and therefor does not require
late static binding.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Anja Leichsenring uploaded patch set 1 01/31/25, 19:44

  2. core-ci voted on patch set 1 V +1 01/31/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73291

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 01/31/25, 20:10

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 01/31/25, 20:42

  5. Jasmina Ließmann voted on patch set 1 CR +1 V +1 01/31/25, 20:43

  6. Anja Leichsenring voted on patch set 1 CR +2 V +2 01/31/25, 21:45

  7. Anja Leichsenring merged patch set 2 01/31/25, 21:46