Review main Merged

88007[BUGFIX] Ensure elements with user-select:none remain editable in CKEditor

Benjamin Kott CR +2 V +2 Easy +4 −0 updated 02/05/25, 08:14

Commit message

Firefox has a pending bug where it incorrectly enforces user-select:
none within contenteditable elements, preventing them from being edited
in CKEditor. To work around this issue, we now enforce user-select: auto
on all elements within the CKEditor content area, ensuring they remain
editable.

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1678667
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1774697

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Benjamin Kott uploaded patch set 1 02/04/25, 10:20

  2. core-ci voted on patch set 1 V +1 02/04/25, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73480

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 02/04/25, 11:43

    Verified fixing the issue in FF/OSX 134.0.2
  4. Andreas Kienast voted on patch set 1 CR +1 02/04/25, 12:25

  5. Andreas Kienast voted on patch set 1 V +1 02/05/25, 07:57

  6. Benjamin Kott voted on patch set 1 CR +2 V +2 02/05/25, 08:06

  7. Benjamin Kott merged patch set 2 02/05/25, 08:14