Review 13.4 Merged

88096[TASK] Avoid $recpid in writelog()

Christian Kuhn CR +2 V +2 Normal +124 −126 updated 02/08/25, 09:38

Commit message

BackendUserAuthentication->writelog():
"int|string $recpid Record PID. Special field used by
tce_main.php. OBSOLETE"

The parameter is unused and not inserted to sys_log.

The patch changes the annotation to null and adapts
callers, including the wrapper method in DataHandler.

This reveals some callers like DataHandler->updateDB()
still submit a value, which is adapted with the patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/08/25, 09:29

  2. core-ci voted on patch set 1 V +1 02/08/25, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73796

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/08/25, 09:38

  4. Christian Kuhn merged patch set 2 02/08/25, 09:38