Review main Merged

88100[BUGFIX] Do not exceed `PHP_INT_MAX` in `TypoScriptFrontendController`

Sascha Nowak CR +2 V +2 Easy +2 −2 updated 02/09/25, 18:48

Commit message

If `CDC->resolveLifetime()` returns `PHP_INT_MAX`,
the timeout calculation may cause an overflow,
leading to a float value being passed to `gmdate()`.
To circumvent this issue, the value may now not be
larger than `PHP_INT_VALUE` anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Sascha Nowak uploaded patch set 1 02/08/25, 11:55

  2. core-ci voted on patch set 1 V +1 02/08/25, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73800

  3. Stefan Bürk updated the commit message in patch set 2 V +1 02/08/25, 20:41

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 02/08/25, 20:41

  5. core-ci voted on patch set 2 V +1 02/08/25, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73810

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 02/09/25, 18:31

  7. Christian Kuhn merged patch set 3 02/09/25, 18:48