Review main Merged

88119[DOCS] Update the Indexing Configuration section

Lina Wolf CR +2 V +2 Hard +210 −413 updated 02/11/25, 17:08

Commit message

Reduce the number of screenshots to those really needed.
In my eyes one screenshot of the indexing configuration
in general should be enough.

I replaced the screenshots with lists of which values to
set. Those lists are also more accessible and easier to
update in the future.

I moved all these very short pages into just one page
and condensed and shortened the texts.

I tested the configuration and removed parts that
no longer worked.

A more detailed description of how the crawler extension
works needs to be described in the extension's manual
and has been removed from here with references to the
extension. (I had to use an absolute link to the
manual as something seems to be broken with that
manual interlinks, will investigate).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 34

Show 14 more files

Review log 1216

  1. Lina Wolf uploaded patch set 1 02/09/25, 18:25

  2. core-ci voted on patch set 1 V +1 02/09/25, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73853

  3. Benni Mack voted on patch set 1 CR +1 V +1 02/10/25, 22:54

  4. Stefan Froemken updated the commit message in patch set 2 CR +1 V +1 02/11/25, 07:32

  5. core-ci voted on patch set 2 V +1 02/11/25, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73966

  6. Stefan Froemken commented on patch set 2 02/11/25, 07:55

    Index.rst:32

    "on each page"

    Index.rst:34

    Remove "is". I prefer: "type of data"

    Index.rst:36

    sentence suddenly stops here

    Index.rst:58

    create

    Index.rst:103

    Nice to have "https". Same two lines below

    Index.rst:107

    lower case

    Index.rst:130

    You already mentioned that in last sentence

    Index.rst:141

    What about: The only division that follows is that of the page on which the result is found.

    Index.rst:173

    Duplicate "a"

    Index.rst:180

    an
  7. Lina Wolf uploaded patch set 3 V +1 02/11/25, 16:32

  8. Lina Wolf commented on patch set 3 02/11/25, 16:32

    Index.rst:32 Reply

    "Each" refers to individual items one by one, implying you must configure it separately for every page. "Any" means it can be done on one or more pages, but it's not required on every single one. So I think "any" is the better choice.

    Index.rst:34 Reply

    Done

    Index.rst:36 Reply

    Done

    Index.rst:58 Reply

    Done

    Index.rst:103 Reply

    Done

    Index.rst:107 Reply

    Indexing Configuration is used a proper noun here as it is a specific concept, not any configuraton for any indexing

    Index.rst:130 Reply

    Done

    Index.rst:141 Reply

    Done

    Index.rst:173 Reply

    Done

    Index.rst:180 Reply

    Done
  9. Lina Wolf uploaded patch set 4 02/11/25, 16:37

  10. Lina Wolf commented on patch set 4 02/11/25, 16:37

    Index.rst:107 Reply

    Changed them all to a propper noun
  11. core-ci voted on patch set 3 V +1 02/11/25, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74000

  12. Stefan Froemken commented on patch set 4 CR +1 02/11/25, 16:41

    Index.rst:32 Reply

    Acknowledged
  13. core-ci voted on patch set 4 V +1 02/11/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74001

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 02/11/25, 17:01

  15. Christian Kuhn commented on patch set 4 02/11/25, 17:03

    renders without warnings on my side which should be fine with the missing +1 testing. i hope that is fine. will merge when backport is green.
  16. Christian Kuhn merged patch set 5 02/11/25, 17:08