Review main Merged

8814[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

Stanislas Rolland CR +2 V +2 Normal +55 −7 updated 06/03/13, 20:49

Commit message

The language and font dropdowns need to initialized after their data
stores are loaded. The text indicator needs to be initialized after
the style sheets are loaded.

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Issues 1

Files 3

Review log 7

  1. Stanislas Rolland commented on patch set 1 02/03/12, 19:23

    Reverted This patchset was reverted in change: I530d5f2c78cdba9174978394669d53f16efa52f1
  2. Stanislas Rolland commented on patch set 1 V 0 02/03/12, 19:23

    by team member; Looks good to me, approved
  3. Stanislas Rolland merged patch set 1 02/03/12, 19:23

  4. Mr. Jenkins commented on patch set 1 02/03/12, 19:23

  5. Wouter Wolters commented on patch set 1 02/03/12, 19:23

    select is undefined if (select.getStore().getCount() > 1) {
  6. Wouter Wolters commented on patch set 1 02/03/12, 19:23

    After this patch applied to master I get the error I posted before this message.
  7. Stanislas Rolland commented on patch set 1 02/03/12, 19:23

    Sorry. This may occur depending on configurattion. Reverted the change and pushed a new one: https://review.typo3.org/8833