Review main Merged

88149[BUGFIX] Fix notice in menu generation

Georg Ringer CR +2 V +2 Easy +1 −1 updated 02/10/25, 20:54

Commit message

An invalid TypoScript menu configuration must not break with a
notice exception.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 02/10/25, 20:03

  2. Georg Ringer commented on patch set 1 02/10/25, 20:03

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/10/25, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73931

  4. Benni Mack commented on patch set 1 CR +1 V +1 02/10/25, 20:28

    no-brainer IMHO
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 02/10/25, 20:29

  6. Christian Kuhn commented on patch set 1 02/10/25, 20:38

    thanks for picking this one up, georg!
  7. Christian Kuhn voted on patch set 1 CR +2 V +2 02/10/25, 20:38

  8. Christian Kuhn merged patch set 2 02/10/25, 20:54