Review main Merged

88156[BUGFIX] Revert edge case language code ch in setup module

Georg Ringer CR +2 V +2 Easy +11 −1 updated 02/21/25, 22:43

Commit message

The simplified language "ch" needs a special treatment
in the setup module.

In the future, we should actually remove "ch"
as we know if from TYPO3 (Locales.php) and allow "ch"
to be Chamorro to be in use soon - this would need
an upgrade wizard and some ecosystem changes,
for this reason, we choose this solution for the time
being.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Georg Ringer uploaded patch set 1 02/10/25, 20:54

  2. Georg Ringer commented on patch set 1 02/10/25, 20:54

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/10/25, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73940

  4. Benni Mack commented on patch set 1 CR -2 02/10/25, 22:18

    I will look into it (not today)
  5. Peter Kraume commented on patch set 1 02/21/25, 11:27

    Can the L10N Team support here in any way?
  6. Benni Mack commented on patch set 1 02/21/25, 12:49

    Sorry, I dug up some things... - "ch" is wrong for "Chinese simplified" as a iso code - "zh" should be used for "Chinese" - "ch" is Chamorro language - similar to Palauan https://en.wikipedia.org/wiki/Chamorro_language
  7. Benni Mack commented on patch set 1 02/21/25, 13:40

    looking at the screenshots in the ticket, we really need to get rid of "ch" on our translation servers...
  8. Benni Mack uploaded patch set 2 V +1 02/21/25, 16:44

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. Benni Mack voted on patch set 2 CR +1 V +1 02/21/25, 16:45

  10. core-ci voted on patch set 2 V +1 02/21/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74527

  11. Stefan Bürk voted on patch set 2 CR +2 V +2 02/21/25, 22:34

  12. Stefan Bürk merged patch set 3 02/21/25, 22:43