Review main Merged

88195[DOCS] Enhance configuration example for ckeditor5-html-support

Oliver Hader CR +2 V +2 Easy +7 −1 updated 02/14/25, 12:00

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Hader uploaded patch set 1 02/12/25, 15:03

  2. core-ci voted on patch set 1 V +1 02/12/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74044

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 02/12/25, 17:15

  4. Chris Müller commented on patch set 1 02/12/25, 17:42

    _AllowSpecificTag.yaml:1

    Shouldn't this comment then moved downwards to the iframe configuration? Now it looks like the new configuration with "i" is part of the iframe config.
  5. Garvin Hicking commented on patch set 2 CR +1 V +1 02/12/25, 17:50

    Published edit on patch set 1.
  6. Garvin Hicking commented on patch set 2 CR +1 V +1 02/12/25, 17:50

    _AllowSpecificTag.yaml:1 Reply

    Indeed, good idea!
  7. core-ci voted on patch set 2 V +1 02/12/25, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74063

  8. Georg Ringer voted on patch set 2 CR +1 V +1 02/12/25, 19:15

  9. Oliver Hader voted on patch set 2 CR +2 V +2 02/14/25, 12:00

  10. Oliver Hader merged patch set 3 02/14/25, 12:00