88200[BUGFIX] Fix race condition on creating select tree elements
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Christian Rath-Ulrich +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Christian Rath-Ulrich +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1116
-
Patrick Schriner uploaded patch set 1 02/12/25, 17:17
-
Garvin Hicking updated the commit message in patch set 2 02/12/25, 17:21
-
core-ci voted on patch set 1 V +1 02/12/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74060
-
core-ci voted on patch set 2 V +1 02/12/25, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74061
-
Andreas Nedbal rebased onto patch set 3
V +103/07/25, 12:56The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/element/select-tree-element.ts -
core-ci voted on patch set 3 V -1 03/07/25, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75300
-
Andreas Nedbal uploaded patch set 4 03/07/25, 13:17
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
Andreas Nedbal uploaded patch set 5
V -103/07/25, 13:18 -
Andreas Nedbal marked it ready for review 03/07/25, 13:19
-
core-ci voted on patch set 4 V -1 03/07/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75301
-
core-ci voted on patch set 5 V +1 03/07/25, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75302
-
Andreas Nedbal voted on patch set 5 CR +1 V +1 03/07/25, 13:28
-
Christian Rath-Ulrich voted on patch set 5 CR +1 V +1 03/19/25, 13:17
-
Benjamin Franzke commented on patch set 5 03/21/25, 07:53
select-tree-element.ts:35For readability I'd prefer: ``` private async initialize(treeWrapperId: string, treeRecordFieldId: string, onFieldChangeItems?: OnFieldChangeItem[]): Promise<void> { await DocumentService.ready(); … } ``` but we still have a dozen places that use then-closures as well, so I don't care too much to change. -
Benjamin Franzke voted on patch set 5 CR +2 V +2 03/21/25, 07:58
-
Benjamin Franzke merged patch set 6 03/21/25, 08:31