Review main Merged

88231[DOCS] Correct PHP syntax and add comments in changelog

Lina Wolf CR +2 V +2 Easy +24 −11 updated 02/18/25, 15:37

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Lina Wolf uploaded patch set 1 02/16/25, 11:24

  2. Lina Wolf updated the commit message in patch set 2 02/16/25, 11:25

  3. core-ci voted on patch set 1 V +1 02/16/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74200

  4. core-ci voted on patch set 2 V +1 02/16/25, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74201

  5. Garvin Hicking commented on patch set 2 02/16/25, 16:36

    good corrections, thank you!

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:121

    ```suggestion // The query parts **must** have the same column counts, and these ```
  6. Stefan Bürk commented on patch set 2 02/16/25, 17:52

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:97

    I would not remove the use for the connection namespace here, will be needed. See other comments.

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:131

    ```suggestion $unionQueryBuilder->createNamedParameter($pageIdOne, Connection::PARAM_INT), ``` Was missing before, but we should add it here as we are dealing with integer values on integer columns.

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:141

    ```suggestion $unionQueryBuilder->createNamedParameter($pageIdTwo, Connection::PARAM_INT), ``` Same as place above.
  7. Lina Wolf commented on patch set 3 V +1 02/18/25, 05:34

    Published edit on patch set 2.
  8. Lina Wolf uploaded patch set 4 02/18/25, 05:37

  9. Lina Wolf commented on patch set 4 02/18/25, 05:37

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:97 Reply

    Done

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:121 Reply

    Fix applied.

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:131 Reply

    Done

    Feature-104631-AddUNIONClauseSupportToTheQueryBuilder.rst:141 Reply

    Done
  10. Lina Wolf uploaded patch set 5 02/18/25, 05:38

  11. core-ci voted on patch set 3 V +1 02/18/25, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74292

  12. core-ci voted on patch set 4 V +1 02/18/25, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74293

  13. core-ci voted on patch set 5 V +1 02/18/25, 05:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74294

  14. Garvin Hicking voted on patch set 5 CR +1 V +1 02/18/25, 06:15

  15. Benni Mack voted on patch set 5 CR +1 V +1 02/18/25, 14:36

  16. Garvin Hicking voted on patch set 5 CR +2 V +2 02/18/25, 15:01

  17. Garvin Hicking merged patch set 6 02/18/25, 15:37