Review main Abandoned

88253[BUGFIX] WS overlay with a deleted record must change result to false

Georg Ringer CR 0 V 0 Easy +3 −0 updated 02/17/25, 20:00

Commit message

If a record has been deleted in a workspace, any check for that record
using BackendUtility::workspaceOL must override the record with false.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 02/17/25, 19:06

  2. Georg Ringer commented on patch set 1 02/17/25, 19:06

    This change is ready for review.
  3. Christian Kuhn commented on patch set 1 02/17/25, 19:17

    be very careful with such changes: *every single* consumer needs to be checked here, this can easily go south if not carefully checked.
  4. core-ci voted on patch set 1 V -1 02/17/25, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74261

  5. Christian Kuhn commented on patch set 1 02/17/25, 19:18

    Reply

    ... as confirmed by functional test fails ...
  6. Christian Kuhn voted on patch set 1 CR -1 02/17/25, 19:18

  7. Christian Kuhn commented on patch set 1 02/17/25, 19:21

    Reply

    I would go so far to reject this patch: With current implementation of the (yes, awful) API, consumers need to check for details of the overlays. DataHandler and friends have checks to look at VersionState and act upon. We should probably not change this in BU, but in consumers until there is better API.
  8. Christian Kuhn commented on patch set 1 02/17/25, 19:24

    Reply Unresolved

    Georg. Could you have a look if this change could be adapted to look at details in the affected consuming code?
  9. Georg Ringer abandoned the change 02/17/25, 20:00

    more a testrun, not a good change ^^