Review main Merged

88262[TASK] Add index to sys_refindex for EXT:form softref_key lookup

Garvin Hicking CR +2 V +2 Easy +3 −1 updated 02/20/25, 12:42

Commit message

This patch adds another sys_refindex key for EXT:form specific
database queries like:

```
SELECT ref_uid
  FROM sys_refindex
 WHERE softref_key='formPersistenceIdentifier'
   AND ref_uid > 0;
```

which would otherwise create a full-table scan and perform bad.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Wand +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1416

  1. Garvin Hicking uploaded patch set 1 02/18/25, 13:00

  2. Garvin Hicking commented on patch set 1 02/18/25, 13:01

    (Note: softref_key has a VARCHAR(30) so the index is added without a character restriction)
  3. core-ci voted on patch set 1 V +1 02/18/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74316

  4. Oliver Wand voted on patch set 1 CR +1 02/18/25, 14:20

  5. Georg Ringer voted on patch set 1 CR +1 V +1 02/18/25, 16:16

  6. Christian Kuhn commented on patch set 1 CR +1 V +1 02/19/25, 16:39

    Ok. I'm not a fan in general, but that's because i think ext:form should solve the problem itself completely differently. I accept there is no way around this additional index with the current code. Its good this index is at least in ext:form only.
  7. Stefan Bürk commented on patch set 1 CR +1 V +1 02/19/25, 18:24

    See lolli's comment.
  8. Christian Kuhn voted on patch set 1 CR -2 02/20/25, 11:01

  9. Christian Kuhn voted on patch set 1 CR 0 V 0 02/20/25, 11:08

  10. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 02/20/25, 11:22

  11. Stefan Bürk voted on patch set 2 CR +1 V +1 02/20/25, 11:25

  12. Christian Kuhn voted on patch set 2 CR +1 V +1 02/20/25, 11:28

  13. core-ci voted on patch set 2 V +1 02/20/25, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74459

  14. Oliver Wand voted on patch set 2 CR +1 02/20/25, 12:09

  15. Garvin Hicking voted on patch set 2 CR +2 V +2 02/20/25, 12:42

  16. Garvin Hicking merged patch set 3 02/20/25, 12:42