Review 13.4 Merged

88266[BUGFIX] Allow empty field to override default in DataHandler

Georg Ringer CR +2 V +2 Easy +16 −1 updated 02/18/25, 15:56

Commit message

Given a TCA type "select" with various options. One option using the
value of "". If a TCA config key "default" is set, which is different
from an empty string, it has been not possible to select the option
with an empty string as value.

As a solution, it is checked if the value handed to DataHandler is part
of the available option items and their values before using the default
config value as fallback.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 02/18/25, 14:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/18/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74325

  3. Georg Ringer voted on patch set 1 CR +2 V +2 02/18/25, 15:56

  4. Georg Ringer merged patch set 2 02/18/25, 15:56