88309[BUGFIX] Properly set loop statement in `DomHelper.nextAll()`
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1214
-
Andreas Kienast uploaded patch set 1 02/21/25, 13:40
-
Andreas Kienast commented on patch set 1 CR -2 02/21/25, 13:41
Will try to add a test -
Andreas Kienast commented on patch set 1 02/21/25, 13:41
dom-helper.ts:39Should be `target.nextElementSibling` -
core-ci voted on patch set 1 V +1 02/21/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74509
-
Andreas Kienast uploaded patch set 2
V +102/21/25, 13:56Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast commented on patch set 2 CR 0 02/21/25, 13:56
dom-helper.ts:39ReplyDone -
Andreas Kienast uploaded patch set 3 02/21/25, 13:56
-
Andreas Kienast uploaded patch set 4 02/21/25, 13:58
-
Andreas Kienast commented on patch set 4 02/21/25, 13:58
Reply
Done -
Christian Kuhn commented on patch set 4 CR +1 V +1 02/21/25, 14:02
thank you so much for this one! -
core-ci voted on patch set 4 V +1 02/21/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74512
-
Stefan Bürk voted on patch set 4 CR +1 V +1 02/21/25, 14:10
-
Andreas Kienast voted on patch set 4 CR +2 V +2 02/21/25, 14:13
-
Andreas Kienast merged patch set 5 02/21/25, 14:19