Review main Merged

88309[BUGFIX] Properly set loop statement in `DomHelper.nextAll()`

Andreas Kienast CR +2 V +2 Easy +35 −4 updated 02/21/25, 14:19

Commit message

The method `DomHelper.nextAll()` was prone to endless loops as the loop
statement was never set after each iteration, which is now fixed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1214

  1. Andreas Kienast uploaded patch set 1 02/21/25, 13:40

  2. Andreas Kienast commented on patch set 1 CR -2 02/21/25, 13:41

    Will try to add a test
  3. Andreas Kienast commented on patch set 1 02/21/25, 13:41

    dom-helper.ts:39

    Should be `target.nextElementSibling`
  4. core-ci voted on patch set 1 V +1 02/21/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74509

  5. Andreas Kienast uploaded patch set 2 V +1 02/21/25, 13:56

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Andreas Kienast commented on patch set 2 CR 0 02/21/25, 13:56

    dom-helper.ts:39 Reply

    Done
  7. Andreas Kienast uploaded patch set 3 02/21/25, 13:56

  8. Andreas Kienast uploaded patch set 4 02/21/25, 13:58

  9. Andreas Kienast commented on patch set 4 02/21/25, 13:58

    Reply

    Done
  10. Christian Kuhn commented on patch set 4 CR +1 V +1 02/21/25, 14:02

    thank you so much for this one!
  11. core-ci voted on patch set 4 V +1 02/21/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74512

  12. Stefan Bürk voted on patch set 4 CR +1 V +1 02/21/25, 14:10

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 02/21/25, 14:13

  14. Andreas Kienast merged patch set 5 02/21/25, 14:19