88318[FEATURE] Provide SEO record title provider
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1619
-
Georg Ringer uploaded patch set 1 02/21/25, 19:39
-
Georg Ringer commented on patch set 1 02/21/25, 19:39
This change is ready for review. -
core-ci voted on patch set 1 V +1 02/21/25, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74539
-
Simon Schaufelberger commented on patch set 1 02/22/25, 21:03
double "a"Feature-106232-ProvideSEORecordTitleProvider.rst:34address is an undefined variable hereext_localconf.php:40if this is executed before seo, why add the lines after seo? -
Georg Ringer uploaded patch set 2
V +102/23/25, 19:24 -
Georg Ringer commented on patch set 2 02/23/25, 19:24
Reply
DoneFeature-106232-ProvideSEORecordTitleProvider.rst:34ReplyDoneext_localconf.php:40ReplyDone -
core-ci voted on patch set 2 V +1 02/23/25, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74592
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/23/25, 21:43
-
Josef Glatz voted on patch set 2 CR +1 V +1 02/24/25, 18:41
-
Chris Müller commented on patch set 2 CR +1 V +1 02/25/25, 12:08
Feature-106232-ProvideSEORecordTitleProvider.rst:33I wonder if we should use DI to inject the RecordTitleProvider as best practise instead GU:mI? This is not a blocker, just a remark. -
Andreas Kienast commented on patch set 2 02/25/25, 14:03
RecordTitleProvider.php:25Interestingly we have a fixture that does exactly the same already: `typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Classes/PageTitle/CustomPageTitleProvider.php`. We may replace this and adjust the tests in the same run, right? -
Georg Ringer commented on patch set 2 02/25/25, 19:47
RecordTitleProvider.php:25Replywe can still leave that fixture, doesn't hurt IMHO -
Benni Mack uploaded patch set 3
CR +1V +103/05/25, 07:42 -
Benni Mack commented on patch set 3 03/05/25, 07:44
Feature-106232-ProvideSEORecordTitleProvider.rst:33ReplyDoneRecordTitleProvider.php:25Replytried doing this but this class is added to EXT:seo, whereas the test + fixture is in EXT:core. So I think leaving the fixture in class is OK IMHO -
Benni Mack voted on patch set 3 CR +1 V +1 03/05/25, 07:44
-
core-ci voted on patch set 3 V +1 03/05/25, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75143
-
Josef Glatz voted on patch set 3 CR +1 V +1 03/05/25, 08:15
-
Benni Mack voted on patch set 3 CR +2 V +2 03/05/25, 10:10
-
Benni Mack merged patch set 4 03/05/25, 10:10