8838[BUGFIX] Fix Content-Transfer-Encoding handling in SwiftMailerAdapter
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 24
-
Steffen Gebert uploaded patch set 2 04/13/13, 06:44
Please don't forget the upcoming release, which will be the result of the master branchclass.t3lib_mail_swiftmaileradapter.php:367The value of $encode is never used. Is this desired? -
Steffen Gebert commented on patch set 2 04/13/13, 06:44
(2 inline comments) Thanks a lot for your patch! Could you please respond to my one inline-comment? -
Björn Steinbrink commented on patch set 2 04/13/13, 06:44
(1 inline comment)class.t3lib_mail_swiftmaileradapter.php:367ReplyUgh, of course not! Initially the default case only had "return" there, but then I realised that the default QP encoder would break things and added the above block and then accidently dropped the new "break;" instead of the "return;". Thanks for catching that! -
Philipp Gampe commented on patch set 3 04/13/13, 06:44
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 04/13/13, 06:44
Of course a unit test would be a great addition here. -
Björn Steinbrink uploaded patch set 3 04/13/13, 06:44
-
Philipp Gampe commented on patch set 4 04/13/13, 06:44
Looks good to me, but someone else must approve Cool thanks for the test. -
Björn Steinbrink uploaded patch set 4 04/13/13, 06:44
-
Philipp Gampe commented on patch set 5 04/13/13, 06:44
According to console log, the commit message has a line exceeding the 74 char limit (has 80). -
Björn Steinbrink uploaded patch set 5 04/13/13, 06:44
-
Björn Steinbrink commented on patch set 5 04/13/13, 06:44
That jenkins error doesn't seem helpful. The report page says that some parsing failed and the error description reads " No report files were found. Configuration error?"... -
Stefan Neufeind commented on patch set 6 04/13/13, 06:44
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 6 1 comment 04/13/13, 06:44
I would prefer that you didn't submit this There is a dependency on another patch, but I can't find a reason for that. In general: why would we force an encoder instead of letting SwiftMailer decide what to do? Each subpart of the message is already decoded before adding it to the message. The default settings of SwiftMailer will use the most appropriate encoder for various kinds of parts. -
Philipp Gampe commented on patch set 6 04/13/13, 06:44
Looks good to me, but someone else must approve Yes it is :) Once the other patch is committed, I check this one again. -
Björn Steinbrink uploaded patch set 6 04/13/13, 06:44
-
Björn Steinbrink commented on patch set 6 04/13/13, 06:44
OK, guess that's a new check, since I didn't change the commit message from the previous submission. -
Björn Steinbrink commented on patch set 6 04/13/13, 06:44
> There is a dependency on another patch, but I can't find a reason for that. Because the unit test uses the setHeaderExposed method introduced by the other patch. > In general: why would we force an encoder instead of letting SwiftMailer decide what to do? Each subpart of the message is already decoded before adding it to the message. The default settings of SwiftMailer will use the most appropriate encoder for various kinds of parts. As the commit message says: SwiftMailer would just use the default quoted-printable encoder. If you just add a Content-Transfer-Encoding header, SwiftMailer doesn't care and you get a mismatch between the header and the encoding that's actually used. -
Mr. Jenkins commented on patch set 1 04/13/13, 06:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3103/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/13/13, 06:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3105/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/13/13, 06:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3108/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/13/13, 06:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3114/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/13/13, 06:44
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3569/ : FAILURE -
Mr. Jenkins commented on patch set 6 04/13/13, 06:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3572/ : SUCCESS -
Jigal van Hemert commented on patch set 6 04/13/13, 06:44
Abandoned The SwiftMailerAdapter will be deprecated in TYPO3 CMS 6.1. It was only meant as a temporary solution to send *most* mails from old API calls using SwiftMailer until the extensions use the new mail API. The extension should by now use the new mail API. No effort will be made to improve the SwiftMailerAdapter or to add functionality.