Review main Merged

88384[TASK] Simplify `FormEngine.getFieldElement()`

Andreas Kienast CR +2 V +2 Easy +7 −11 updated 02/28/25, 13:39

Commit message

The method `FormEngine.getFieldElement()` is simplified with this
commit. The form element is not queried anymore everytime from DOM.
Instead, `FormEngine.formElement` is used which in turn uses internal
DOM references. The same is done for retrieving the actual field via
`namedItem()`.

The appendix `_hr` is not used anymore since TYPO3 v7 and is therefore
removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 02/27/25, 13:24

  2. Andreas Kienast uploaded patch set 2 02/27/25, 13:28

  3. core-ci voted on patch set 1 V +1 02/27/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74834

  4. core-ci voted on patch set 2 V +1 02/27/25, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74835

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/28/25, 00:50

  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 02/28/25, 13:19

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 02/28/25, 13:21

  8. Andreas Kienast merged patch set 3 02/28/25, 13:39