8839[BUGFIX] Fix handling of parameterized headers in the SwiftMailerAdapter
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 21
-
Steffen Gebert commented on patch set 1 04/13/13, 06:47
(2 inline comments) Thanks for your patch! Could you add unit tests for this? This would also make it more clear, how to reproduce this bug.class.t3lib_mail_swiftmaileradapter.php:344Please add parameter name @param string $header ...class.t3lib_mail_swiftmaileradapter.php:345@retunclass.t3lib_mail_swiftmaileradapter.php:347I think it would be nice, if there would be a comment that explains how the input of this function looks like and what the result is. Some checks about e.g. what happens, when there's no ; (and throw an exception otherwise) would make it more robust. I'm sorry that I can't contribute too much myself, as I'm not so deep into that topic! -
Steffen Gebert commented on patch set 2 1 comment 04/13/13, 06:47
I would prefer that you didn't submit this -
Steffen Gebert uploaded patch set 2 04/13/13, 06:47
-
Björn Steinbrink commented on patch set 2 04/13/13, 06:47
(1 inline comment) Next version will have tests, they're somewhat ugly though, as the adapter class combines conversion and the actual mail sending, so I had to dig more holes into the class. Additionally, the type-switch for the headers is combined with that code that handles the individual types, so the tests rely on the header name which is an implementation detail. But I don't think I want to refactor the adapter class, so...class.t3lib_mail_swiftmaileradapter.php:59ReplygetHeaders() returns an object, these are always passed by reference.class.t3lib_mail_swiftmaileradapter.php:59ReplyI replied in the previous version, but gerrit seems to have omitted mentioning my replies in the list at the bottom *sigh* getHeaders() returns an object, which is passed by reference.class.t3lib_mail_swiftmaileradapter.php:347ReplyOK. Parameters are optional though, so throwing an exception would be a bug. The current code already does the right thing, i.e. simply returning an empty array when there are no parameters.class.t3lib_mail_swiftmaileradapter.php:372ReplyNot trailing whitespace, just the EOL marker. -
Björn Steinbrink uploaded patch set 3 04/13/13, 06:47
-
Stefan Neufeind commented on patch set 4 04/13/13, 06:47
(3 inline comments) Can reading the headers really be moved? -
Philipp Gampe commented on patch set 4 04/13/13, 06:47
Looks good to me, but someone else must approve -
Björn Steinbrink uploaded patch set 4 04/13/13, 06:47
-
Stefan Neufeind commented on patch set 5 04/13/13, 06:47
(1 inline comment) -
Stefan Neufeind commented on patch set 5 04/13/13, 06:47
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 5 3 comments 04/13/13, 06:47
I would prefer that you didn't submit this The SwiftMailerAdapter was not meant to handle all kinds of mails (it also can't handle nested subparts). The idea was to provide a mechanism which could handle most cases until extensions started using the new mail API. If you really want to support parameterized headers then they should be handled as RFC 2231 describes, including charsets, encoding, continuation. -
Philipp Gampe commented on patch set 5 04/13/13, 06:47
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 V 0 04/13/13, 06:47
Checked with unit tests, somebody should send some mails too. -
Björn Steinbrink uploaded patch set 5 04/13/13, 06:47
-
Björn Steinbrink commented on patch set 5 04/13/13, 06:47
(1 inline comment) -
Mr. Jenkins commented on patch set 1 04/13/13, 06:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3104/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/13/13, 06:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3106/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/13/13, 06:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3107/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/13/13, 06:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3113/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/13/13, 06:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3568/ : SUCCESS -
Jigal van Hemert commented on patch set 5 04/13/13, 06:47
Abandoned The SwiftMailerAdapter will be deprecated in TYPO3 CMS 6.1. It was only meant as a temporary solution to send *most* mails from old API calls using SwiftMailer until the extensions use the new mail API. The extension should by now use the new mail API. No effort will be made to improve the SwiftMailerAdapter or to add functionality.