Review main Merged

88411[BUGFIX] Remove duplicated event listener

Oli Bartsch CR +2 V +2 Easy +0 −2 updated 03/03/25, 10:23

Commit message

Multi record selection comes with default
event listener JS modules for the "edit"
and "delete" actions.

The Recordlist defines its own event listener
to additionally handle the "columns only"
mode, which allows editing multiple records
with just a subset of fields.

Therefore, the default JS module is now
removed as it interfered with the custom
logic, leading to the strange behavior where,
depending on the loading order, the "columns only"
mode sometimes worked and sometimes not.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 02/28/25, 16:46

  2. core-ci voted on patch set 1 V +1 02/28/25, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74912

  3. Oli Bartsch rebased onto patch set 2 V +1 03/03/25, 08:31

  4. core-ci voted on patch set 2 V +1 03/03/25, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74994

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 03/03/25, 10:17

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 03/03/25, 10:18

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 03/03/25, 10:23

  8. Oli Bartsch merged patch set 3 03/03/25, 10:23