Review main Merged

8844[FEATURE] Add "if" function to includeCSS and includeJS

Tolleiv Nietsch CR +2 V +2 Easy +20 −0 updated 01/06/19, 11:15

Commit message

The includeJS / CSS / ... blocks lack the ability to
add TypoScript conditions to them. Even if some workarounds
exist, it doesn't seem to be too much overhead to add the
checks for a bit more convenience.

The related documentation changes are kept in issue #33724.

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Markus Klein +1
    • Henrik Ziegenhain +1
    • Alexander Grein +1
  • Verified V +2
    • Stefan Galinski +2
    • Alexander Grein +1

Files 1

Review log 11

  1. Tolleiv Nietsch commented on patch set 1 02/08/12, 20:48

    Well - iirc the stdWrap RFC wasn't passed through for some reason, but the if. part still makes sense on his own.
  2. Tolleiv Nietsch uploaded patch set 2 02/08/12, 20:48

  3. Markus Klein commented on patch set 1 02/08/12, 20:48

    (1 inline comment) Why not adding stdWrap? Please post the forge documentation ticket link.
    ... some workarounds exist, ...
  4. Markus Klein commented on patch set 1 02/08/12, 20:48

    I would prefer that you didn't submit this Please correct the typo in the commit message. -1 until link to documentation ticket is posted here and is added as related issue in forge.
  5. Markus Klein commented on patch set 2 02/08/12, 20:48

    Looks good to me, but someone else must approve
  6. Stefan Galinski commented on patch set 2 V 0 02/08/12, 20:48

    by team member; Looks good to me, approved That's a really cool new feature and I already had a live case for such a feature recently. Thanks, Tolleiv!
  7. Alexander Grein commented on patch set 2 02/08/12, 20:48

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 02/08/12, 20:48

  9. Mr. Jenkins commented on patch set 2 02/08/12, 20:48

  10. Stefan Galinski merged patch set 2 02/08/12, 20:48

  11. Henrik Ziegenhain commented on patch set 2 01/06/19, 11:15

    Looks good to me, but someone else must approve