8844[FEATURE] Add "if" function to includeCSS and includeJS
Commit message
Review
-
Code review CR +2
- Stefan Galinski +2
- Markus Klein +1
- Henrik Ziegenhain +1
- Alexander Grein +1
-
Verified V +2
- Stefan Galinski +2
- Alexander Grein +1
Files 1
Review log 11
-
Tolleiv Nietsch commented on patch set 1 02/08/12, 20:48
Well - iirc the stdWrap RFC wasn't passed through for some reason, but the if. part still makes sense on his own. -
Tolleiv Nietsch uploaded patch set 2 02/08/12, 20:48
-
Markus Klein commented on patch set 1 02/08/12, 20:48
(1 inline comment) Why not adding stdWrap? Please post the forge documentation ticket link.... some workarounds exist, ... -
Markus Klein commented on patch set 1 02/08/12, 20:48
I would prefer that you didn't submit this Please correct the typo in the commit message. -1 until link to documentation ticket is posted here and is added as related issue in forge. -
Markus Klein commented on patch set 2 02/08/12, 20:48
Looks good to me, but someone else must approve -
Stefan Galinski commented on patch set 2 V 0 02/08/12, 20:48
by team member; Looks good to me, approved That's a really cool new feature and I already had a live case for such a feature recently. Thanks, Tolleiv! -
Alexander Grein commented on patch set 2 02/08/12, 20:48
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 02/08/12, 20:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3109/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/08/12, 20:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3142/ : SUCCESS -
Stefan Galinski merged patch set 2 02/08/12, 20:48
-
Henrik Ziegenhain commented on patch set 2 01/06/19, 11:15
Looks good to me, but someone else must approve