Review main Merged

88449[TASK] Annotate correct return type in PageRepository

Sascha Egerer CR +2 V +2 Easy +6 −3 updated 03/05/25, 06:10

Commit message

The method getDefaultConstraints() returns a list of
strings or CompositeExpression.
The return annotation must accurately reflect this.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1722

  1. Sascha Egerer uploaded patch set 1 03/03/25, 19:46

  2. core-ci voted on patch set 1 V +1 03/03/25, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75044

  3. Oliver Klee commented on patch set 1 03/03/25, 20:30

    This sentences seems to be cut off.
  4. Sascha Egerer updated the commit message in patch set 2 V +1 03/03/25, 20:39

  5. Oliver Klee commented on patch set 2 03/03/25, 20:41

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 03/03/25, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75048

  7. Fabien Udriot voted on patch set 2 CR +1 V +1 03/04/25, 12:46

  8. Benjamin Franzke commented on patch set 2 03/04/25, 13:05

    Minor nitpick: Better "[TASK] Annotate correct" if there is no read end-user facing bug here.
    Is that actually a BUG that `string`s are being returned? `ModifyDefaultConstraintsForDatabaseQueryEvent` annotates that is expects `CompositeExpression[]` for `$constraints`, but it seems that codepaths like ``` $constraints['fe_group'] = QueryHelper::stripLogicalOperatorPrefix( $this->getMultipleGroupsWhereClause($field, $table) ); ``` violate that.
  9. Benjamin Franzke uploaded patch set 3 CR +1 V +1 03/04/25, 13:21

  10. Benjamin Franzke commented on patch set 3 03/04/25, 13:21

    Reply

    Done

    Reply

    nvm, `string` is fine.
  11. Benjamin Franzke uploaded patch set 4 CR +1 V +1 03/04/25, 13:28

  12. core-ci voted on patch set 3 V -1 03/04/25, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75102

  13. core-ci voted on patch set 4 V +1 03/04/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75104

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 03/04/25, 19:19

  15. Benjamin Franzke voted on patch set 4 CR +2 V +2 03/05/25, 03:20

  16. Benjamin Franzke commented on patch set 4 CR 0 V 0 03/05/25, 03:26

    12.4 seems not to be affected, `getDefaultConstraints()` doesn't exist there and `PageRepository::enableFields` has a string return type annotation.
  17. Benjamin Franzke updated the commit message in patch set 5 CR +1 V +1 03/05/25, 03:26

  18. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/05/25, 03:26

  19. core-ci voted on patch set 5 V +1 03/05/25, 03:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75122

  20. Garvin Hicking voted on patch set 5 CR +1 V +1 03/05/25, 06:00

  21. Benjamin Franzke voted on patch set 5 CR +2 V +2 03/05/25, 06:10

  22. Benjamin Franzke merged patch set 6 03/05/25, 06:10