Review main Merged

8848[BUGFIX] Remove menu type special.userdefined

Tolleiv Nietsch CR +2 V +2 Easy +0 −3 updated 06/03/13, 20:49

Commit message

The manual says that this type has been removed in 4.6 in favor of
userfunctions.
Besides that, the block makes use of includeMakeMenu(), which doesn't
exist anymore.
Therefore I'd say it's safe to remove the block.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Wouter Wolters +1
    • Philipp Gampe +1

Files 1

Review log 9

  1. Markus Klein commented on patch set 1 03/15/12, 07:08

    (3 inline comments) Has to be removed in 4.6 too, as the mentioned function doesn't exist there either.
    been removed
    userfunctions. or a userfunction. Besides that
    doesn't exist anymore
  2. Stefan Neufeind commented on patch set 2 1 comment 03/15/12, 07:08

    Looks good to me, but someone else must approve
  3. Markus Klein uploaded patch set 2 03/15/12, 07:08

  4. Steffen Ritter commented on patch set 2 V 0 03/15/12, 07:08

    by team member; Looks good to me, approved
  5. Philipp Gampe commented on patch set 2 03/15/12, 07:08

    Verified; Looks good to me, but someone else must approve Nothing to test here.
  6. Mr. Jenkins commented on patch set 1 03/15/12, 07:08

  7. Mr. Jenkins commented on patch set 2 03/15/12, 07:08

  8. Wouter Wolters commented on patch set 2 03/15/12, 07:08

    Verified; Looks good to me, but someone else must approve
  9. Steffen Ritter merged patch set 2 03/15/12, 07:08