Review main Merged

88502[TASK] Avoid obsolete perm check in DH->copyRecord_raw()

Christian Kuhn CR +2 V +2 Easy +3 −14 updated 03/05/25, 14:24

Commit message

Using DataHandler->recordInfoWithPermissionCheck() in low
level copyRecord_raw() is obsolete since all callers already
perform permission checks directly or indirectly. The method
call can be substituted with BackendUtility::getRecord(),
saves a few queries and makes things more obvious.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 03/05/25, 13:14

  2. core-ci voted on patch set 1 V +1 03/05/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75175

  3. Christian Kuhn uploaded patch set 2 V +1 03/05/25, 13:29

  4. Christian Kuhn updated the commit message in patch set 3 03/05/25, 13:30

  5. Benni Mack voted on patch set 3 CR +1 V +1 03/05/25, 13:39

  6. core-ci voted on patch set 2 V +1 03/05/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75178

  7. core-ci voted on patch set 3 V +1 03/05/25, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75179

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 03/05/25, 14:18

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 03/05/25, 14:24

  10. Christian Kuhn merged patch set 4 03/05/25, 14:24