Review main Abandoned

88561[TASK] Introduce "settings" Data Processor for FLUIDTEMPLATE

Lina Wolf CR 0 V 0 Hard +312 −1 updated 10/22/25, 13:27

Commit message

The new "settings" Data Processor is introduced for `FLUIDTEMPLATE`
to provide access to TypoScript settings and constants, bridging the
gap between `PAGEVIEW` and `FLUIDTEMPLATE`.

While `PAGEVIEW` templates already expose these settings automatically,
`FLUIDTEMPLATE` previously required a custom Data Processor to access
them.

The processor supports two modes:
- `page` (default): Merges TypoScript settings with constants, casting all
  values to strings.
- `site`: Provides site configuration settings while preserving their types.

This ensures a consistent way to access settings in Fluid templates.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 14

Review log 1216

  1. Lina Wolf uploaded patch set 1 03/10/25, 16:03

  2. Lina Wolf marked it work in progress 03/10/25, 16:03

  3. core-ci voted on patch set 1 V -1 03/10/25, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75428

  4. Lina Wolf uploaded patch set 2 V -1 03/10/25, 18:24

  5. Lina Wolf uploaded patch set 3 03/10/25, 18:31

  6. core-ci voted on patch set 2 V +1 03/10/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75435

  7. core-ci voted on patch set 3 V +1 03/10/25, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75436

  8. Lina Wolf uploaded patch set 4 V +1 03/11/25, 15:39

  9. Lina Wolf marked it ready for review 03/11/25, 15:39

  10. core-ci voted on patch set 4 V +1 03/11/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75484

  11. Benni Mack commented on patch set 4 03/28/25, 23:35

    That's a completely new feature. I personally think we could a) and add it as Feature for v14.0 b) ship it as part of an extension "early-adopter-v14" :) - so people can use some features for v14 right now.
  12. Georg Ringer commented on patch set 4 03/29/25, 05:45

    Don't like the name pagesettings much, is site settings better?
  13. Lina Wolf commented on patch set 4 03/29/25, 05:53

    Reply

    Well the difference is that the settings in the site (site settings) are not enriched by TypoScript constants. Therefore the pure site settings are the same across the whole site while the settings enriched with TypoScript constants can differ from page to page
  14. Benni Mack marked it work in progress 04/11/25, 20:40

  15. Benni Mack commented on patch set 4 04/11/25, 20:40

    Marking as WIP - awaiting feedback from @ben@bnf.dev
  16. Lina Wolf abandoned the change 10/22/25, 13:27

    Will be solved in another way