Review main Merged

88621[BUGFIX] Provide proper label for rte fields

Georg Ringer CR +2 V +2 Easy +1 −0 updated 03/24/25, 11:37

Commit message

Use the label of a field also within the rte configuration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 03/17/25, 20:57

  2. Georg Ringer commented on patch set 1 03/17/25, 20:57

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/17/25, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75739

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 03/18/25, 07:43

    When applied, the 'label' gets forwarded in the CKEditor JSON config array (with key 'label') and ultimately lands here: ``` <div class="ck-blurred ck ck-content ck-editor__editable ck-rounded-corners ck-editor__editable_inline" lang="en-us" dir="ltr" role="textbox" aria-label="rte_1 description. Press ⌥0 for help." contenteditable="true" style="min-height:300px;min-width:auto;"> ```
  5. Michael Telgkamp voted on patch set 1 CR +1 V +1 03/18/25, 09:18

  6. Benni Mack voted on patch set 1 CR +2 V +2 03/24/25, 11:37

  7. Benni Mack merged patch set 2 03/24/25, 11:37