Review 13.4 Merged

88750[TASK] Extract settings tree diff into a object and add tests

Benjamin Franzke CR +2 V +2 Hard +320 −91 updated 03/25/25, 16:01

Commit message

Split the `computeSettingsDiff` into a self-constructing data object
and a form-data transformation backed by the site settings factory.
The diff algorithm does not depend on any site context and is
therefore implemented generically. Currently missing tests are added
along the way.
Arrays are now transformed into settings objects as early as possible in
order to reduce the amount of different arrays formats (settings map vs
tree) that are passed around.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benjamin Franzke commented on patch set 1 03/25/25, 15:46

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/25/25, 15:47

  3. core-ci voted on patch set 1 V +1 03/25/25, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76285

  4. Benjamin Franzke merged patch set 2 03/25/25, 16:01