Review 12.4 Merged

88813[BUGFIX] Allow empty config.doctype as HTML5

Benni Mack CR +2 V +2 Easy +2 −1 updated 03/27/25, 21:59

Commit message

A specific change for HTML5 conformity was
added to the main branch but was leftover in
v12 branch as PHP 8 conformity in #102297.

The main change is that TYPO3 needs to understand
that "config.doctype = " and config.doctype as
not set is added as the same.

This is a low-level drive-by fix in v12,
and already adressed via the Enum in v13+

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 03/27/25, 21:50

  2. Garvin Hicking voted on patch set 1 CR +1 03/27/25, 21:54

  3. Garvin Hicking voted on patch set 1 V +1 03/27/25, 21:55

  4. Georg Ringer voted on patch set 1 CR +1 V +1 03/27/25, 21:55

  5. core-ci voted on patch set 1 V +1 03/27/25, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76522

  6. Benni Mack voted on patch set 1 CR +2 V +2 03/27/25, 21:59

  7. Benni Mack merged patch set 2 03/27/25, 21:59