Review main Merged

88848[BUGFIX] Check if parameter is an array before starting autotagging

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/08/25, 09:59

Commit message

If using the feature `frontend.cache.autoTagging` the provided parameter
`data` must be an array. If using records with no translation,
`DatabaseRecordLinkBuilder` can set it to 0, therefore an additional
check is needed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sascha Nowak +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Georg Ringer uploaded patch set 1 03/31/25, 13:28

  2. core-ci voted on patch set 1 V +1 03/31/25, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76721

  3. Georg Ringer commented on patch set 1 03/31/25, 13:38

    This change is ready for review.
  4. Benni Mack commented on patch set 2 V +1 03/31/25, 15:30

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 03/31/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76724

  6. Benni Mack voted on patch set 2 CR +1 04/08/25, 08:48

  7. Christian Kuhn commented on patch set 2 04/08/25, 09:18

    ContentObjectRenderer.php:473

    i think we should use $this->data here to be consistent with the usages below and in case the event above changed it. will push.
  8. Christian Kuhn uploaded patch set 3 CR +1 V +1 04/08/25, 09:19

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 04/08/25, 09:20

  10. Benni Mack voted on patch set 3 CR +1 V +1 04/08/25, 09:21

  11. Sascha Nowak voted on patch set 3 CR +1 04/08/25, 09:24

  12. core-ci voted on patch set 3 V +1 04/08/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77191

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/25, 09:33

  14. Christian Kuhn merged patch set 4 04/08/25, 09:59