Review main Merged

8888[FEATURE] Add subjectField to Form Wizard TS

Florian Scholz CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 19

  1. Steffen Ritter merged patch set 1 02/13/12, 12:58

  2. Steffen Gebert commented on patch set 1 02/13/12, 12:58

    Philipp, what abou our "patch for a patch" convention? Would be nice, if you could fix such tiny things especially for first-time contributors like Florian. Florian, thanks a lot for your patch! Will upload a fixed version.
  3. Stefan Neufeind commented on patch set 3 1 comment 02/13/12, 12:58

    Looks good to me, but someone else must approve
  4. Markus Klein uploaded patch set 3 02/13/12, 12:58

  5. Markus Klein commented on patch set 3 02/13/12, 12:58

    Looks good to me, but someone else must approve Fixed the commit message. (Resolves)
  6. Steffen Gebert uploaded patch set 2 02/13/12, 12:58

  7. Steffen Ritter commented on patch set 3 V 0 02/13/12, 12:58

    by team member; Looks good to me, approved
  8. Steffen Ritter commented on patch set 3 02/13/12, 12:58

    i know, im searching for the right place place because tsref does not really fit...
  9. Steffen Ritter commented on patch set 3 02/13/12, 12:58

    Verified; Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 1 02/13/12, 12:58

    (2 inline comments) see comments
    Remove the last part, see below
    Fixes: #32132 Releases: 4.7 please have a look at http://wiki.typo3.org/CommitMessage_Format_(Git)

    Mail.php:355 Reply

    No, look at unified diff ... "\ No newline at end of file" Just a newline char '\n' is added at the end of the line. This is valid, according to UNIX text files guideline, fine for PHP (which threads it as part of the "?>") and not against CGL (which just cares about additional newlines, that break the output).
  11. Philipp Gampe voted on patch set 3 V 0 02/13/12, 12:58

  12. Philipp Gampe commented on patch set 3 02/13/12, 12:58

    Just a note: This needs documentation.
  13. Philipp Gampe commented on patch set 3 02/13/12, 12:58

    typo3/sysext/form/Documentation/Manual/en/manual.sxw
  14. Philipp Gampe commented on patch set 3 02/13/12, 12:58

    Looks good to me, but someone else must approve @Steffen I did this several times already ... sorry for my laziness. Markus took care already :) Otherwise this patch looks good. @Florian Can you post a sample form in forge tracker (just the form TS and maybe your changed template file source). This would simplify testing a lot.
  15. Philipp Gampe commented on patch set 3 02/13/12, 12:58

    (1 inline comment)
  16. Mr. Jenkins commented on patch set 1 02/13/12, 12:58

  17. Mr. Jenkins commented on patch set 2 02/13/12, 12:58

  18. Mr. Jenkins commented on patch set 3 02/13/12, 12:58

  19. Steffen Ritter commented on patch set 3 02/13/12, 12:58

    I just created a ticket at the ts-ref. Hoplefilly Francois will move it to the right place if needed http://forge.typo3.org/issues/33880