Review main Merged Breaking

88933[!!!][TASK] Remove fields fe_groups & visible from sys_file_metadata

Georg Ringer CR +2 V +2 Normal +56 −64 updated 04/07/25, 08:39

Commit message

The mentioned fields do more harm than good as users might think that
the record can be restricted by using those fields but actually those
are just regular content fields.

To minimize additional confusion, the field status is moved to the tab
"Metadata".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Georg Ringer uploaded patch set 1 04/03/25, 08:04

  2. Georg Ringer commented on patch set 1 04/03/25, 08:04

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/03/25, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76928

  4. Andreas Kienast updated the commit message in patch set 2 V +1 04/03/25, 09:45

  5. core-ci voted on patch set 2 V +1 04/03/25, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76931

  6. Benni Mack commented on patch set 2 04/04/25, 10:30

    Breaking-106503-RemovalOfFieldFromSys_file_metadata.rst:33

    I think we should mention that these fields are only in use when EXT:filemetadata is installed (I mean, it's not all of the installations out there, using the fields)

    Breaking-106503-RemovalOfFieldFromSys_file_metadata.rst:41

    can also be done in a third-party extension instead of site package extension
  7. Benni Mack commented on patch set 3 V +1 04/04/25, 10:32

    Published edit on patch set 2.
  8. core-ci voted on patch set 3 V +1 04/04/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76999

  9. Benni Mack commented on patch set 3 CR +1 V +1 04/06/25, 12:13

    Breaking-106503-RemovalOfFieldFromSys_file_metadata.rst:33 Reply

    Done

    Breaking-106503-RemovalOfFieldFromSys_file_metadata.rst:41 Reply

    Done
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 04/07/25, 08:31

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 04/07/25, 08:39

  12. Christian Kuhn merged patch set 4 04/07/25, 08:39