Review main Merged

88941[TASK] Only load record for permission handling once

Benni Mack CR +2 V +2 Normal +39 −45 updated 04/08/25, 11:54

Commit message

DataHandler fetches the whole record within
BE_USER->recordEditAccessInternals() when only the
uid is handed over, to then retreives the record.

This has now been optimized to always hand over the
full record, which saves some DB calls in DataHandler.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Benni Mack uploaded patch set 1 04/03/25, 18:29

  2. Benni Mack marked it work in progress 04/03/25, 18:30

  3. core-ci voted on patch set 1 V +1 04/03/25, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76959

  4. Christian Kuhn commented on patch set 1 04/08/25, 10:21

    This change is ready for review.

    DataHandler.php:5291

    let's sanitize this with an additional is_array() check.
  5. Christian Kuhn commented on patch set 1 CR -1 04/08/25, 10:21

    will finish.
  6. Christian Kuhn uploaded patch set 2 CR -1 V +1 04/08/25, 10:36

  7. Christian Kuhn commented on patch set 2 04/08/25, 10:36

    DataHandler.php:5291 Reply

    Done
  8. core-ci voted on patch set 2 V +1 04/08/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77197

  9. Christian Kuhn updated the commit message in patch set 3 V +1 04/08/25, 10:49

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 04/08/25, 10:55

  11. core-ci voted on patch set 3 V +1 04/08/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77198

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 04/08/25, 11:29

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/25, 11:53

  14. Christian Kuhn merged patch set 4 04/08/25, 11:54