Review main Merged

8915[BUGFIX] Remove early return in PageTreeDataProvider

Tolleiv Nietsch CR +2 V +2 Easy +23 −23 updated 06/03/13, 20:49

Commit message

t3lib_tree_pagetree_Data_Provider does an early
return which makes it impossible to use the hook
which comes some lines later.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
    • Stefan Galinski +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Stefan Galinski +1
    • Philipp Gampe +1

Files 1

Review log 18

  1. Tolleiv Nietsch commented on patch set 1 V 0 02/10/12, 13:49

    by team member; Looks good to me, approved Another try - patch is obvious, the pagetree kept working with the applied patch - so +1 be testing as well.
  2. Tolleiv Nietsch merged patch set 1 02/10/12, 13:49

  3. Philipp Gampe commented on patch set 1 02/10/12, 13:49

    @Tolleiv please only vote +1 if you are the first voter And you can change the author by executing $ git commit --amend --author="User <email@address.tld>" I will do this for you now and push a new patchset.
  4. Tolleiv Nietsch commented on patch set 2 02/10/12, 13:49

    Wait - the author was right from the beginning on and in this case he's a core member - why would I vote +1 then?
  5. Tolleiv Nietsch commented on patch set 2 V 0 02/10/12, 13:49

    by team member; Looks good to me, approved Sorry - right, first tester always +1 (my fault). Anyways now I'm the second one ;)
  6. Markus Klein commented on patch set 2 02/10/12, 13:49

    (1 inline comment)
    For BUGFIX we have Fixes here.
  7. Tolleiv Nietsch commented on patch set 3 V 0 02/10/12, 13:49

    by team member; Looks good to me, approved
  8. Markus Klein uploaded patch set 3 02/10/12, 13:49

  9. Stefan Galinski commented on patch set 3 02/10/12, 13:49

    Verified; Looks good to me, but someone else must approve Didn't tested the hook, but the code looks fine and the pagetree still works and I'am sure Georg has tested the code with the hook, right?
  10. Georg Ringer commented on patch set 3 02/10/12, 13:49

    if you dont test if, don't give a +1 on verified!
  11. Philipp Gampe uploaded patch set 2 02/10/12, 13:49

  12. Philipp Gampe commented on patch set 2 02/10/12, 13:49

    Verified; Looks good to me, but someone else must approve
  13. Philipp Gampe commented on patch set 3 02/10/12, 13:49

    Verified; Looks good to me, but someone else must approve reapply vote @Markus thanks ... we should have a Jenkins rule for this
  14. Mr. Jenkins commented on patch set 1 02/10/12, 13:49

  15. Mr. Jenkins commented on patch set 2 02/10/12, 13:49

  16. Mr. Jenkins commented on patch set 3 02/10/12, 13:49

  17. Wouter Wolters commented on patch set 3 02/10/12, 13:49

    Looks good to me, but someone else must approve
  18. Stefan Galinski commented on patch set 3 02/10/12, 13:49

    @Georg: Just to make it clear... This patch didn't changed the hook itself and so I didnt't tested it's functionality. The change itself was tested by me. Hopefully this clarifies your remark.