Review main Merged

89299[BUGFIX] Allow `DEFAULT NULL` for `VARCHAR`

Andreas Kienast CR +2 V +2 Normal +68 −8 updated 05/07/25, 12:09

Commit message

The database schema generated by `DefaultTcaSchema` lacks the ability to
generate `VARCHAR` fields with `NULL` as their default value.

The code is adjusted to generate `DEFAULT NULL` for input fields that do
not exceed the maximum length of 255 characters.

Since this code adjusts existing database schema with potentially
negative impact, this patch is aimed for main only.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1522

  1. Andreas Kienast uploaded patch set 1 05/05/25, 12:37

  2. Andreas Kienast commented on patch set 1 05/05/25, 12:41

  3. core-ci voted on patch set 1 V -1 05/05/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78524

  4. Andreas Kienast uploaded patch set 2 V -1 05/05/25, 12:58

  5. core-ci voted on patch set 2 V +1 05/05/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78528

  6. Stefan Bürk commented on patch set 2 05/05/25, 13:11

    Blog.php:92

    `$this->title` is typed $title as not nullable .. so allowing null des not make sense for the argument on the setter or property needs to be adjusted above

    Blog.php:97

    `$this->title` is typed $title as not nullable .. using nullable string return type does not make much sense. or property needs to be adjusted above
  7. Andreas Kienast commented on patch set 2 CR -1 05/05/25, 13:38

    Blog.php:92 Reply

    I guess I'm officially old enough for glasses... acknowledged.

    Blog.php:97 Reply

    Acknowledged
  8. Andreas Kienast uploaded patch set 3 CR -1 V +1 05/05/25, 13:39

  9. Andreas Kienast uploaded patch set 4 05/05/25, 13:39

  10. core-ci voted on patch set 4 V +1 05/05/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78532

  11. Andreas Kienast uploaded patch set 5 V +1 05/06/25, 10:04

  12. Andreas Kienast uploaded patch set 6 05/06/25, 10:05

  13. core-ci voted on patch set 6 V +1 05/06/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78594

  14. core-ci voted on patch set 5 V +1 05/06/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78593

  15. Andreas Kienast uploaded patch set 7 V +1 05/07/25, 07:42

  16. core-ci voted on patch set 7 V +1 05/07/25, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78624

  17. Andreas Kienast uploaded patch set 8 V +1 05/07/25, 08:04

  18. core-ci voted on patch set 8 V +1 05/07/25, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78625

  19. Stefan Bürk voted on patch set 8 CR +1 V +1 05/07/25, 08:18

  20. Anja Leichsenring voted on patch set 8 CR +1 V +1 05/07/25, 09:05

  21. Georg Ringer voted on patch set 8 CR +2 V +2 05/07/25, 12:09

  22. Georg Ringer merged patch set 9 05/07/25, 12:09