89299[BUGFIX] Allow `DEFAULT NULL` for `VARCHAR`
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Important-106656-AllowDEFAULTNULLForVarcharFields.rstnew+60 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php4+6 −6
Review log 1522
-
Andreas Kienast uploaded patch set 1 05/05/25, 12:37
-
Andreas Kienast commented on patch set 1 05/05/25, 12:41
I found this while analyzing https://review.typo3.org/c/Packages/TYPO3.CMS/+/84751 -
core-ci voted on patch set 1 V -1 05/05/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78524
-
Andreas Kienast uploaded patch set 2
V -105/05/25, 12:58 -
core-ci voted on patch set 2 V +1 05/05/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78528
-
Stefan Bürk commented on patch set 2 05/05/25, 13:11
Blog.php:92`$this->title` is typed $title as not nullable .. so allowing null des not make sense for the argument on the setter or property needs to be adjusted aboveBlog.php:97`$this->title` is typed $title as not nullable .. using nullable string return type does not make much sense. or property needs to be adjusted above -
Andreas Kienast commented on patch set 2 CR -1 05/05/25, 13:38
Blog.php:92ReplyI guess I'm officially old enough for glasses... acknowledged.Blog.php:97ReplyAcknowledged -
Andreas Kienast uploaded patch set 3
CR -1V +105/05/25, 13:39 -
Andreas Kienast uploaded patch set 4 05/05/25, 13:39
-
core-ci voted on patch set 4 V +1 05/05/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78532
-
Andreas Kienast uploaded patch set 5
V +105/06/25, 10:04 -
Andreas Kienast uploaded patch set 6 05/06/25, 10:05
-
core-ci voted on patch set 6 V +1 05/06/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78594
-
core-ci voted on patch set 5 V +1 05/06/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78593
-
Andreas Kienast uploaded patch set 7
V +105/07/25, 07:42 -
core-ci voted on patch set 7 V +1 05/07/25, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78624
-
Andreas Kienast uploaded patch set 8
V +105/07/25, 08:04 -
core-ci voted on patch set 8 V +1 05/07/25, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78625
-
Stefan Bürk voted on patch set 8 CR +1 V +1 05/07/25, 08:18
-
Anja Leichsenring voted on patch set 8 CR +1 V +1 05/07/25, 09:05
-
Georg Ringer voted on patch set 8 CR +2 V +2 05/07/25, 12:09
-
Georg Ringer merged patch set 9 05/07/25, 12:09