Review main Merged

89370[BUGFIX] Allow to stop disabled task

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 05/13/25, 20:48

Commit message

Since also disabled tasks can be executed, it
is now possible to stop them, once executed.

This is important in case the task does not stop
automatically, e.g. due to some error on execution.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Oli Bartsch uploaded patch set 1 05/13/25, 13:48

  2. core-ci voted on patch set 1 V +1 05/13/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78847

  3. Oli Bartsch updated the commit message in patch set 2 V +1 05/13/25, 14:24

  4. core-ci voted on patch set 2 V +1 05/13/25, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78848

  5. Markus Klein voted on patch set 2 CR +1 05/13/25, 14:37

  6. Markus Klein commented on patch set 2 05/13/25, 14:38

    maybe also for v13?
  7. Oli Bartsch commented on patch set 2 05/13/25, 14:59

    Reply

    Also thought about 13, but Benni pointed me to https://review.typo3.org/c/Packages/TYPO3.CMS/+/89324, which introduced the bug by using TCA with a disabled field set. This is therefore only relevant for main.
  8. Markus Klein commented on patch set 2 05/13/25, 15:47

    I tried to test, but backend fails with PHP Warning: Undefined array key "NEW6823696191019" in /var/www/html/typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php line 97
  9. Markus Klein commented on patch set 2 05/13/25, 15:48

    Reply

    my bad... wrong DB , not up2date
  10. Markus Klein voted on patch set 2 V +1 05/13/25, 15:59

  11. Benni Mack voted on patch set 2 CR +2 V +2 05/13/25, 20:48

  12. Benni Mack merged patch set 3 05/13/25, 20:48