89504[BUGFIX] Add "info" action in context menu for folders
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Oli Bartsch uploaded patch set 1 05/21/25, 21:50
-
core-ci voted on patch set 1 V +1 05/21/25, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79332
-
Andreas Kienast updated the commit message in patch set 2
V +105/22/25, 05:26 -
core-ci voted on patch set 2 V +1 05/22/25, 05:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79348
-
Andreas Kienast commented on patch set 2 05/22/25, 05:38
Does it really make any sense to have this available? The only information you get are the storage and the parent folder path. -
Oli Bartsch commented on patch set 2 05/22/25, 09:17
Reply
It's IMO the only feasible way you get the combined identifier. -
Andreas Kienast commented on patch set 2 05/22/25, 10:07
FileProvider.php:256Now we can simply return `true` here. There _might_ be the case that `$this->record` is null, but then the whole class will collapse anyway. -
Oli Bartsch uploaded patch set 3
V +105/22/25, 13:52 -
core-ci voted on patch set 3 V +1 05/22/25, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79373
-
Oli Bartsch commented on patch set 3 05/22/25, 14:05
Reply
DoneFileProvider.php:256ReplyTo make the intention clear, I changed this to `return $this->record !== null;` -
Georg Ringer voted on patch set 3 CR +1 V +1 05/23/25, 06:03
-
Benni Mack voted on patch set 3 CR +1 V +1 05/26/25, 10:15
-
Oli Bartsch voted on patch set 3 CR +2 V +2 05/26/25, 10:47
-
Oli Bartsch merged patch set 4 05/26/25, 10:47