Review main Merged

89573[BUGFIX] Proper check for array key during indexing

Georg Ringer CR +2 V +2 Easy +6 −5 updated 05/28/25, 08:31

Commit message

Check if the array key exists to avoid exceptions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 05/28/25, 06:25

  2. Georg Ringer commented on patch set 1 05/28/25, 06:26

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/28/25, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79602

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 05/28/25, 07:12

    ("soft-verified" - I assume this happens with very specific/unparsable PDF files?!)
  5. Oliver Klee voted on patch set 1 CR +1 05/28/25, 07:55

  6. Christian Kuhn rebased onto patch set 2 CR +1 V +1 05/28/25, 08:03

  7. Christian Kuhn commented on patch set 2 CR +1 V +1 05/28/25, 08:04

    rebased due to funny relation chain.
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 05/28/25, 08:05

  9. Oliver Klee voted on patch set 2 CR +1 05/28/25, 08:11

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 05/28/25, 08:23

  11. core-ci voted on patch set 2 V +1 05/28/25, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79612

  12. Christian Kuhn merged patch set 3 05/28/25, 08:31