Review main Merged

89582[TASK] Revert record type permission handling

Oli Bartsch CR +2 V +2 Normal +1 −76 updated 05/31/25, 08:40

Commit message

This reverts #94408 as well as the corresponding
follow up #106697.

Reason for revert:

The implemented permission handling fails to
correctly generate the `$validItems` list. The
added "exclude" logic operates on the static
`items` array, but calculating `$validTypes`
requires accounting for all dynamic sources
such as itemsProcFunc and TSconfig options
like `addItems`. As implemented, this would
only work for record type fields using a TCA
type that directly defines `items`, limiting
its applicability.

Extending AbstractItemProvider highlights this
issue and arguably misuses the abstraction. At
this stage, reliably determining `$validTypes`
would require duplicating significant parts
of the data provider logic. Furthermore, as
said, record type field values might originate
from group fields or other complex configurations
as well, not just "select".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 05/28/25, 09:59

  2. core-ci voted on patch set 1 V +1 05/28/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79628

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 05/28/25, 10:58

  4. Torben Hansen voted on patch set 1 CR +1 V +1 05/31/25, 05:22

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 05/31/25, 08:40

  6. Oli Bartsch merged patch set 2 05/31/25, 08:40