Review 13.4 Merged

89588[BUGFIX] Fix negated disallowed check in drag-uploader

Oli Bartsch CR +2 V +2 Easy +8 −8 updated 05/29/25, 09:38

Commit message

`checkDisallowedExtensions()` is expected to return
false if the extension is disallowed, the negation was
incorrectly migrated with #102415.

This mistake is hard to guess, given the ambiguous name,
therefore the methods for allow-list and disallow-list
are now renamed to reflect their intended result and
the conditions are adapted to check the particular
cases.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 05/29/25, 09:25

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/29/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79668

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 05/29/25, 09:38

  4. Oli Bartsch merged patch set 2 05/29/25, 09:38